Attention is currently required from: Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84008?usp=email )
Change subject: libpayload: Use defined length movs ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File payloads/libpayload/arch/x86/pt.S:
https://review.coreboot.org/c/coreboot/+/84008/comment/aa7cc9dc_665f95e8?usp... : PS3, Line 132: mov %eax, (%rsi, %rcx, 8) : mov %ebx, 4(%rsi, %rcx, 8)
Why are these ones fine?
I guess because the actual problematic lines were the `mov $0...` ones because the size is not implied (it is for the other cases by the register size). Is that right Arthur? If we change the `mov %eax,...` above for consistency, I'd say we should change these too.