Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63522 )
Change subject: superio/smsc/sch5545: Drop `_PRS` for static devices ......................................................................
superio/smsc/sch5545: Drop `_PRS` for static devices
The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object.
In addition, drop `IGNORE_IASL_MISSING_DEPENDENCY` from the only mainboard using the SCH5545 code, `dell/snb_ivb_workstations`.
Change-Id: Ic462bd3dfa287744d4f733561de81c09c1c397e6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/dell/snb_ivb_workstations/Kconfig M src/superio/smsc/sch5545/acpi/superio.asl 2 files changed, 0 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/63522/1
diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig b/src/mainboard/dell/snb_ivb_workstations/Kconfig index 8416a0f..788f5a1 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig @@ -20,9 +20,6 @@
if BOARD_DELL_SNB_IVB_WORKSTATIONS
-config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config MAINBOARD_DIR default "dell/snb_ivb_workstations"
diff --git a/src/superio/smsc/sch5545/acpi/superio.asl b/src/superio/smsc/sch5545/acpi/superio.asl index 97303c2..20278b4 100644 --- a/src/superio/smsc/sch5545/acpi/superio.asl +++ b/src/superio/smsc/sch5545/acpi/superio.asl @@ -232,22 +232,6 @@ ) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0x00, 0x00) - { - FixedIO ( - 0x0060, // Address - 0x01, - ) - FixedIO ( - 0x0064, // Address - 0x01, - ) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) Method (_PSW, 1, NotSerialized) // _PSW: Power State Wake { KBFG = Arg0 @@ -268,15 +252,6 @@ IRQ (Edge, ActiveHigh, Exclusive) {12} })
- Name (_PRS, ResourceTemplate () - { - StartDependentFn (0x00, 0x00) - { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) - Method (_PSW, 1, NotSerialized) { MSFG = Arg0