Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41654 )
Change subject: drivers/ipmi: Avoid NULL pointer dereference
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41654/1/src/drivers/ipmi/ipmi_kcs_o...
File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/41654/1/src/drivers/ipmi/ipmi_kcs_o...
PS1, Line 254: acpigen_write_name_byte("_UID", conf->uid);
Should we skip _UID and generate the rest of entries as usual?
https://review.coreboot.org/c/coreboot/+/41654/1/src/drivers/ipmi/ipmi_kcs_o...
PS1, Line 262: if (conf) {
always true
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d1cfe3f9b55288eeb55ab8785d857993e3989c0
Gerrit-Change-Number: 41654
Gerrit-PatchSet: 1
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 May 2020 16:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment