Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46068 )
Change subject: arch/x86/smbios: Update SMBIOS type 7
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46068/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/46068/1/src/arch/x86/smbios.c@490
PS1, Line 490: return 3; /* Unknown */
Please define a macro or enum.
Just use the SMBIOS_CACHE_OP_MODE_UNKNOWN macro you've added.
https://review.coreboot.org/c/coreboot/+/46068/1/src/arch/x86/smbios.c@859
PS1, Line 859: number_of_sets
Done
I don't see any new patchset. Maybe you forgot to push it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb5d3346454ffb2291613dc2aa24b31d10c2e04
Gerrit-Change-Number: 46068
Gerrit-PatchSet: 1
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 13:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-MessageType: comment