Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31870 )
Change subject: sb/via/common: Fix indirect includes ......................................................................
sb/via/common: Fix indirect includes
Change-Id: Id6565abd15d6904effbf55e5d1ea8664ef338c83 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31870 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/via/common/early_smbus_delay.c M src/southbridge/via/common/early_smbus_is_busy.c M src/southbridge/via/common/early_smbus_print_error.c M src/southbridge/via/common/early_smbus_read_byte.c M src/southbridge/via/common/early_smbus_reset.c M src/southbridge/via/common/early_smbus_wait_until_ready.c M src/southbridge/via/common/via_early_smbus.h 7 files changed, 17 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/southbridge/via/common/early_smbus_delay.c b/src/southbridge/via/common/early_smbus_delay.c index 0c04112..c75152c 100644 --- a/src/southbridge/via/common/early_smbus_delay.c +++ b/src/southbridge/via/common/early_smbus_delay.c @@ -14,7 +14,8 @@ * GNU General Public License for more details. */
-#include "via_early_smbus.h" +#include <arch/io.h> +#include <device/early_smbus.h>
/** * \brief Brief delay for SMBus transactions diff --git a/src/southbridge/via/common/early_smbus_is_busy.c b/src/southbridge/via/common/early_smbus_is_busy.c index f719cb9..8321a55 100644 --- a/src/southbridge/via/common/early_smbus_is_busy.c +++ b/src/southbridge/via/common/early_smbus_is_busy.c @@ -14,6 +14,9 @@ * GNU General Public License for more details. */
+#include <arch/io.h> +#include <device/early_smbus.h> + #include "via_early_smbus.h"
/** diff --git a/src/southbridge/via/common/early_smbus_print_error.c b/src/southbridge/via/common/early_smbus_print_error.c index 8a59193..cf65b2e 100644 --- a/src/southbridge/via/common/early_smbus_print_error.c +++ b/src/southbridge/via/common/early_smbus_print_error.c @@ -14,6 +14,8 @@ * GNU General Public License for more details. */
+#include <device/early_smbus.h> + #include "via_early_smbus.h"
/** diff --git a/src/southbridge/via/common/early_smbus_read_byte.c b/src/southbridge/via/common/early_smbus_read_byte.c index cc137cb..4f6e29e 100644 --- a/src/southbridge/via/common/early_smbus_read_byte.c +++ b/src/southbridge/via/common/early_smbus_read_byte.c @@ -14,6 +14,9 @@ * GNU General Public License for more details. */
+#include <arch/io.h> +#include <device/early_smbus.h> + #include "via_early_smbus.h"
/** diff --git a/src/southbridge/via/common/early_smbus_reset.c b/src/southbridge/via/common/early_smbus_reset.c index 6145ab8..4497540 100644 --- a/src/southbridge/via/common/early_smbus_reset.c +++ b/src/southbridge/via/common/early_smbus_reset.c @@ -14,6 +14,9 @@ * GNU General Public License for more details. */
+#include <arch/io.h> +#include <device/early_smbus.h> + #include "via_early_smbus.h"
/** diff --git a/src/southbridge/via/common/early_smbus_wait_until_ready.c b/src/southbridge/via/common/early_smbus_wait_until_ready.c index 879bc23..6b18936 100644 --- a/src/southbridge/via/common/early_smbus_wait_until_ready.c +++ b/src/southbridge/via/common/early_smbus_wait_until_ready.c @@ -14,6 +14,9 @@ * GNU General Public License for more details. */
+#include <arch/io.h> +#include <device/early_smbus.h> + #include "via_early_smbus.h"
/** diff --git a/src/southbridge/via/common/via_early_smbus.h b/src/southbridge/via/common/via_early_smbus.h index 5f66822..1dce9b6 100644 --- a/src/southbridge/via/common/via_early_smbus.h +++ b/src/southbridge/via/common/via_early_smbus.h @@ -35,6 +35,7 @@ /** * \brief SMBus IO ports in relation to the base IO port */ + #define SMBHSTSTAT(base) ((u16)base + 0x0) #define SMBSLVSTAT(base) ((u16)base + 0x1) #define SMBHSTCTL(base) ((u16)base + 0x2) @@ -48,6 +49,3 @@ #define SMBSLVDATA (base) ((u16)base + 0xa)
#define SMBUS_TIMEOUT (100*1000*10) - -#include <device/early_smbus.h> -#include <arch/io.h>