[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of...

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou.

Subrata Banik has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/84997?usp=email )

Change subject: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of rtd3
......................................................................

Patch Set 13:

(2 comments)

File src/mainboard/google/brya/variants/rull/gpio.c:

https://review.coreboot.org/c/coreboot/+/84997/comment/42a65199_6148738c?usp... :
PS13, Line 31: 	PAD_CFG_GPO(GPP_B11, 1, DEEP),
why you are touching WLAN PIN in this CL ?

https://review.coreboot.org/c/coreboot/+/84997/comment/cb77b72f_b1bdd98d?usp... :
PS13, Line 142: 
why empty line ?