[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31619 )

Change subject: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/gpio_defs.h:

https://review.coreboot.org/#/c/31619/2/src/soc/intel/cannonlake/include/soc... 
PS2, Line 261: #define GPIORXBUFDIS_SHIFT			9
> The register bits should apply to both PCH-H and PCH-LP, don't they? Maybe `gpio. […]

https://review.coreboot.org/c/coreboot/+/31621