Attention is currently required from: Arthur Heymans, Nicholas Chin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67818 )
Change subject: Documentation/flashing_firmware: Add info about SPI flash header
......................................................................
Patch Set 2:
(1 comment)
File Documentation/tutorial/flashing_firmware/hp_spi_header_mb.jpg:
PS2:
https://jpeg-optimizer.com/ at 80% quality greatly reduces file size: https://i.imgur.com/fnYULmj. […]
It would be good to document the unwritten rule of "any images in the coreboot repo used in documentation should be as small as possible so as not to bloat the repo too much" and mention image optimizer websites (without linking to any site in particular).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2bf1244adfb78872340f212519c6ab33e26646a
Gerrit-Change-Number: 67818
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 09 Oct 2022 11:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment