Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34707 )
Change subject: x86/smm: Rename SMM_SUBREGION_CHIPSET to _IED
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34707/5/src/include/cpu/x86/smm.h
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/34707/5/src/include/cpu/x86/smm.h@5...
PS5, Line 597: Chipset specific area
Update comment too?
FWIW, it was originally named chipset because IED is a intel specific name. cpu/x86/ is supposed to generic. Though, I'm not sure it matters much in practice. One could do something like the following:
SMM_SUBREGION_CHIPSET,
SMM_SUBREGION_IED = SMM_SUBREGION_IED,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82a09878a6adedb33fdaf4289c1299136140d1f6
Gerrit-Change-Number: 34707
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Aug 2019 07:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment