EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57016 )
Change subject: mb/google/brya: Add ALC1019_NAU88L25B support ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57016/comment/cde1b8d4_35f04c85 PS1, Line 208: register "vref_impedance" = "2" # 125kOhm : register "micbias_voltage" = "6" # 2.754 : register "sar_threshold_num" = "4" : register "sar_threshold[0]" = "0x0c" : register "sar_threshold[1]" = "0x1c" : register "sar_threshold[2]" = "0x38" : register "sar_threshold[3]" = "0x60" : register "sar_hysteresis" = "1" : register "sar_voltage" = "0" # VDDA : register "sar_compare_time" = "0" # 500ns : register "sar_sampling_time" = "0" # 2us
are these just copied from glados? 😋
this is what vendor suggest when first time I bring up it in TGL.
https://review.coreboot.org/c/coreboot/+/57016/comment/05f427fe_82ff407e PS1, Line 219: register "short_key_debounce" = "2" # 100ms : register "jack_insert_debounce" = "7" # 512ms : register "jack_eject_debounce" = "7" # 512ms
did you check headphone jack detection yet?
yes, HP is functional as well.