Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support
......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/#/c/31682/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31682/5//COMMIT_MSG@14
PS5, Line 14: to the kernel
Please add an URL to the corresponding Linux kernel change.
Done
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c
File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@43
PS4, Line 43: firmware-variant
is firmware-name already an approved _DSD entry that we are reusing? If not don't we have to registe […]
Based on offline discussion, using firmware-name for now to make forward progress.
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@72
PS4, Line 72: .write_acpi_tables = pci_rom_write_acpi_tables,
will remove
Done
https://review.coreboot.org/#/c/31682/3/src/include/device/pci_ids.h
File src/include/device/pci_ids.h:
https://review.coreboot.org/#/c/31682/3/src/include/device/pci_ids.h@2094
PS3, Line 2094: #define PCI_DEVICE_ID_INTEL_ISHB 0x9dfc
0x9dfc only for ISH for cannonlake pch, change to PCI_DEVICE_ID_INTEL_CNL_ISHB instead?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 7
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Tue, 05 Mar 2019 22:28:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: rushikesh s kadam
rushikesh.s.kadam@intel.com
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment