Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30178/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30178/2//COMMIT_MSG@7 PS2, Line 7: fro for
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/... PS2, Line 250: case SKU_0_EKKO: : case SKU_1_EKKO: : case SKU_2_EKKO: : case SKU_3_EKKO: : case SKU_0_BARD: : case SKU_1_BARD: : case SKU_2_BARD: : case SKU_3_BARD: : pl2_id = PL2_ID_BARD_EKKO;
bard&ekko SKU ids should not be same as Vaye&Panthon […]
Okay. So, the port 5 needs to be kept enabled.
Can you please add break at the end of this case?