Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31938 )
Change subject: src/arch/mips: Fix checkpatch warnings and errors ......................................................................
src/arch/mips: Fix checkpatch warnings and errors
This patch will fix these checkpatch errors in src/arch/mips/. - src/arch/mips/ashldi3.c:22: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' - src/arch/mips/bootblock_simple.c:35: WARNING: braces {} are not necessary for any arm of this statement
Change-Id: Ic859913b93dc8ed6ff64b551c8a6baf72d28c75a Signed-off-by: Asami Doi d0iasm.pub@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31938 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/arch/mips/ashldi3.c M src/arch/mips/bootblock_simple.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/arch/mips/ashldi3.c b/src/arch/mips/ashldi3.c index 9ee40efa..f68d78e 100644 --- a/src/arch/mips/ashldi3.c +++ b/src/arch/mips/ashldi3.c @@ -19,7 +19,7 @@ #errror "What endian are you!?" #endif
-typedef unsigned word_type; +typedef unsigned int word_type; long long __ashldi3(long long u, word_type b);
struct DWstruct { diff --git a/src/arch/mips/bootblock_simple.c b/src/arch/mips/bootblock_simple.c index 40987d8..84029eb 100644 --- a/src/arch/mips/bootblock_simple.c +++ b/src/arch/mips/bootblock_simple.c @@ -32,10 +32,10 @@
bootblock_mmu_init();
- if (init_extra_hardware()) { + if (init_extra_hardware()) printk(BIOS_ERR, "bootblock_simple: failed to init HW.\n"); - } else { + else run_romstage(); - } + halt(); }