Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48113 )
Change subject: libpayload: Provide API to expose MMU memery ranges for ARM64
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include...
File payloads/libpayload/include/arm64/arch/mmu.h:
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include...
PS4, Line 199: includes
include
https://review.coreboot.org/c/coreboot/+/48113/4/payloads/libpayload/include...
PS4, Line 202: mmu_get_ranges
How about mmu_get_used_ranges? Otherwise, please at least mention "used" in the function comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39b24aefc9dbe530169b272e839d0e1e7c697742
Gerrit-Change-Number: 48113
Gerrit-PatchSet: 4
Gerrit-Owner: Meng-Huan Yu
menghuan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 08:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment