[coreboot-gerrit] Change in coreboot[master]: dram: Add basic DDR4 SPD parsing

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34680 )

Change subject: dram: Add basic DDR4 SPD parsing
......................................................................

Patch Set 8:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c 
File src/device/dram/ddr4.c:

https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@54 
PS3, Line 54: ((1 << 4) - 1)
> I think it would be great to provide unified mask/bit extraction macros, e. […]

Ack

https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@56 
PS3, Line 56: 	reg8 = spd[13] & ((1 << 4) - 1);
> I personally find hex values easier to read.

Ack

https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@120 
PS3, Line 120: 		dimm->ddr_frequency = selected_freq;
> besides "configured memory speed" there's also a field for "maximum memory speed". […]

Ack