Attention is currently required from: Shaunak Saha, Furquan Shaikh, Caveh Jalali, Nick Vaccaro.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50419 )
Change subject: mb/google/volteer: Add settings for noise mitgation
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/50419/comment/7c326a59_0ac2d512
PS1, Line 341: VR_DOMAIN_GT
I followed the FSP code to get those domains. In FSP code they are talking about all these domains.
FSP has a comment that "Only VCCIN VR Exist" and the GetMaxNumVrs() function is hardcoded to return 1, so even though the FSP header has an array of 5 values it seems that only the first value will ever be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50419
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idda7697da3e88d3c98107ae9808f94df62e0567a
Gerrit-Change-Number: 50419
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 17 Feb 2021 18:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment