Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74229 )
Change subject: mb/google/rex: Update Flash Layout to fit WP_RO within 4MB ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74229/comment/a9795bed_d219f233 PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB.
The board was apparently added with 8 MB, so why is it too big now? What optimization is done? […]
Thank you for adding that paragraph. It helped me.
https://review.coreboot.org/c/coreboot/+/74229/comment/3f973961_7ed1bda1 PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB. : : Changes for chromeos.fmd: : : SI_BIOS: : RW_SECTION_A/B: Reduce to 7MB. : RW_LEGACY: Reduce to 1MB. : RW_MISC: Increased to 1MB. : RW_UNUSED: 3MB (reserved) : WP_RO: Reduce to 4MB : : Additionally, ensure RW_SECTION_B region starts at 16MB boundary in the : SPI Flash.
I am sorry you are feeling this way. […]
A lot of my comments were ignorance and thinking errors on my part. Sorry about that.
File src/mainboard/google/rex/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74229/comment/4b9e3d4b_3e2834c9 PS1, Line 7: 7M
Changing 7092K to 7M is cosmetic, isn’t it? […]
I am sorry, I miscalculated 7 * 1024 and thought it’s 7092K instead of 7168K. So it’s not a cosmetic change. I am sorry for the noise.