Attention is currently required from: Ravi kumar. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: Add SHRM firmware support ......................................................................
Patch Set 79:
(3 comments)
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49392/comment/62a12f4b_6b32da47 PS79, Line 110: none Why not $(CBFS_PRERAM_COMPRESS_FLAG)?
File src/soc/qualcomm/sc7280/shrm_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49392/comment/894210e7_31c50bb4 PS79, Line 16: if (!shrm_fw_entry) nit: unnecessarily complicated way to write
if (!selfload(&shrm_fw_prog))
https://review.coreboot.org/c/coreboot/+/49392/comment/c12a36c6_2ac44ad5 PS79, Line 21: \n nit: please refrain from randomly inserting extra newlines in the console unless there's actually a big "break" in the firmware flow that deserves to visually stand out (e.g. QcLib entry and exit, but not this).