Attention is currently required from: Stefan Reinauer.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68695 )
Change subject: ifdtool: Move regions to seperate file ......................................................................
Patch Set 1:
(8 comments)
File util/ifdtool/ifdtool.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/85b64ae2_5bd78b24 PS1, Line 215: const frba_t *frba); adding a line without newline at end of file
File util/ifdtool/regions.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/8bc10e46_a16dae30 PS1, Line 47: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/5d261625_2dcb5a34 PS1, Line 66: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/c47f0415_a33e4f98 PS1, Line 78: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/3c6be25b_3d160ce8 PS1, Line 88: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/5cb2a337_51683eea PS1, Line 98: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/9fc0a613_d51c9a9f PS1, Line 122: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/d8d2a45f_31243d9a PS1, Line 142: } adding a line without newline at end of file