Attention is currently required from: Andrey Petrov, Pratikkumar V Prajapati, Ronak Kanabar, Subrata Banik, Wonkyu Kim.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75816?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/intel/fsp2_0: Correct FSP performance timestamp unit
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/fsp_timestamp.c:
https://review.coreboot.org/c/coreboot/+/75816/comment/7f381da9_40819083 :
PS2, Line 56: TIMESTAMP_MS
isn't it getting converted here and L:47 to MS before printing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75816?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aec4f63beddbd7ce6e8e3fc1b53a45da2ee0b00
Gerrit-Change-Number: 75816
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 06:23:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment