Attention is currently required from: Tim Wawrzynczak, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63562 )
Change subject: mb/google/brya/baseboard/nissa: Configure I2C lcnt and hcnt
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63562/comment/dc852860_a86ae2c3
PS2, Line 9: Configure lcnt and hcnt directly to give the required frequency, tHIGH
okay, just want to remind if too close too 400, different board may over 400. […]
Thanks, I wasn't aware that this was a consideration. I'll double check with our hardware engineer and update this if needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f877c1f0cd9aacd3fa152890b7ef82e059f78
Gerrit-Change-Number: 63562
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 00:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment