Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 )
Change subject: string: implement strspn, strcspn, atol
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@140
PS3, Line 140: while (*str != 0) {
nit: both of these loops look like they really want to be for-loops.
Ack
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@159
PS3, Line 159: while (*str != 0) {
nit: also for loops
Ack
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@174
PS3, Line 174:
According to the man page atol() needs to be equivalent to strtol(str, NULL, 10) (except for error c […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762
Gerrit-Change-Number: 34450
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yuji Sasaki
sasakiy@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Aug 2019 22:54:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment