Attention is currently required from: Angel Pons.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel: Introduce MCHBAR accessor functions
......................................................................
Patch Set 42:
(2 comments)
Patchset:
PS42:
Thank you
File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45517/comment/f98cf9f5_ef1a5ac7
PS42, Line 170: #include "memmap.h"
duplicated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5
Gerrit-Change-Number: 45517
Gerrit-PatchSet: 42
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 12:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment