[coreboot-gerrit] [L] Change in coreboot[main]: superio/ite/common: Add common driver for GPIO and LED configuration

[Nicholas Sudsgaard (Code Review)]

Attention is currently required from: Michał Żygowski, Nico Huber.

Nicholas Sudsgaard has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83355?usp=email )

Change subject: superio/ite/common: Add common driver for GPIO and LED configuration
......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File src/superio/ite/common/gpio.c:

https://review.coreboot.org/c/coreboot/+/83355/comment/daf3db79_fb4a4fcc?usp... :
PS1, Line 16: This ITE SIO GPIO driver support up to 10 GPIO sets
> Changed per suggestion

Done

File src/superio/ite/common/ite_gpio.h:

https://review.coreboot.org/c/coreboot/+/83355/comment/728d961a_24de8e39?usp... :
PS1, Line 15: ITE_GPIO_PULLUP_DIS,
            : 	ITE_GPIO_PULLUP_EN
> It has been converted to a single flag: ITE_GPIO_PULLUP_ENABLE

Done

https://review.coreboot.org/c/coreboot/+/83355/comment/0448bede_af4f9fde?usp... :
PS1, Line 63: ITE_LED_FREQ_2Hz_DUTY_50 = 3,
            : 	ITE_LED_FREQ_0P25HZ_DUTY_25 = 4,
            : 	ITE_LED_FREQ_0P25HZ_DUTY_75 = 5,
            : 	ITE_LED_FREQ_0P125HZ_DUTY_25 = 6,
            : 	ITE_LED_FREQ_0P125Hz_DUTY_75 = 7,
            : 	ITE_LED_FREQ_0P4Hz_DUTY_20 = 8,
            : 	ITE_LED_FREQ_0P5Hz_DUTY_50 = 16,
            : 	ITE_LED_FREQ_0P125Hz_DUTY_50 = 24,
> Applied.

Done