25 Nov
2024
25 Nov
'24
1:45 p.m.
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84774?usp=email )
Change subject: soc/mediatek/common: Add read16/write16 support for PMIF ......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/pmif.c:
https://review.coreboot.org/c/coreboot/+/84774/comment/07139a62_d5b26686?usp... : PS3, Line 101: void pmif_spmi_write_field(struct pmif *arb, u32 slvid, u32 reg,
So you're saying the code in [ref](https://chrome-internal-review.googlesource. […]
The mask here should be 0xFF, these will be fixed in the next version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84774?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3adbbaaf247a8bbd99627cf089b5b55fcf4fb115
Gerrit-Change-Number: 84774
Gerrit-PatchSet: 6
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 25 Nov 2024 13:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Comment-In-Reply-To: Yidi Lin yidilin@google.com