Attention is currently required from: David Wu, Tim Wawrzynczak, Alan Huang. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Enable LAN driver ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/ea5979b9_12ec0884 PS5, Line 84: 0x05af This is incorrect. Let's define the led in the buganizer.
https://review.coreboot.org/c/coreboot/+/58105/comment/0756af18_4cfccfb3 PS5, Line 85: register "wake" = "0" I think you can remove this but let's follow up b/204289108 to see if we need to change the wakeup pin
https://review.coreboot.org/c/coreboot/+/58105/comment/2a3f4218_83555f40 PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)" IIUC, this setting will disable the wake on lan. Could you please double check it?