Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52489 )
Change subject: sb/intel/lynxpoint: Add SerialIO UART console support
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
BDW's pch_uart_init() is never called. Hence I assume things work
without it or maybe never worked?
Ah, yes, it's never called, and things do *not* work without it. I got the code to work in CB:37553 patchset 3 and CB:37568 patchset 2 back in 2019, but I added a call to pch_uart_init() in romstage.c of the mainboard port.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022
Gerrit-Change-Number: 52489
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 20 May 2021 09:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment