21 Apr
2023
21 Apr
'23
12:54 p.m.
Attention is currently required from: Nico Huber, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74441 )
Change subject: [WIP] cpu/intel/speedstep: Use acpigen_write_processor_device() ......................................................................
Patch Set 3:
(1 comment)
File src/cpu/intel/speedstep/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174710): https://review.coreboot.org/c/coreboot/+/74441/comment/f1e19e85_aeb94020 PS3, Line 108: #if 0 Consider removing the code enclosed by this #if 0 and its #endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/74441
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1950ceac7daf8d8e91c74f1090c7451cb92e100
Gerrit-Change-Number: 74441
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 21 Apr 2023 10:54:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment