Attention is currently required from: Raul Rangel, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60081 )
Change subject: mb/google/guybrush: Set TPM to to be kernel power managed.
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60081/comment/53d7bdb6_7b6503c7
PS4, Line 346: KERNEL_POWER
Is it FW_POWER_MANAGED?
When PSP_S0I3_RESUME_VERSTAGE is running it needs to be kernel managed to cause the shutdown command to be sent, this is skipped in firmware power managed case. See https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I206022cc2a29690186206966c5d45bd55c303248
Gerrit-Change-Number: 60081
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 13 Dec 2021 17:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment