Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84093?usp=email )
Change subject: mb/google/brox: Disable Thunderbolt device ......................................................................
mb/google/brox: Disable Thunderbolt device
This feature is not required in Brox devices. Hence disable the concerned device.
BUG=None TEST=Build Brox firmware and boot to OS. Ensure that the concerned device is disabled in the OS.
Change-Id: I355852c780c552e6f9b2c28508f53580f392c1b9 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84093 Reviewed-by: Sowmya Aralguppe sowmya.aralguppe@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Reviewed-by: Abhishek Pandit-Subedi abhishekpandit@chromium.org --- M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb M src/mainboard/google/brox/variants/brox/overridetree.cb 2 files changed, 4 insertions(+), 18 deletions(-)
Approvals: Abhishek Pandit-Subedi: Looks good to me, but someone else must approve Ren Kuo: Looks good to me, approved Sowmya Aralguppe: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index a82b4f0..22e15ac 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -160,11 +160,11 @@ }" end device ref dtt on end - device ref tbt_pcie_rp0 on end - device ref tbt_pcie_rp2 on end + device ref tbt_pcie_rp0 off end + device ref tbt_pcie_rp2 off end device ref tcss_xhci on end - device ref tcss_dma0 on end - device ref tcss_dma1 on end + device ref tcss_dma0 off end + device ref tcss_dma1 off end device ref xhci on end device ref shared_sram on end device ref i2c0 on diff --git a/src/mainboard/google/brox/variants/brox/overridetree.cb b/src/mainboard/google/brox/variants/brox/overridetree.cb index 18baa5d..37c4e01 100644 --- a/src/mainboard/google/brox/variants/brox/overridetree.cb +++ b/src/mainboard/google/brox/variants/brox/overridetree.cb @@ -268,20 +268,6 @@ end end end - device ref tcss_dma0 on - chip drivers/intel/usb4/retimer - register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)" - use tcss_usb3_port1 as dfp[0].typec_port - device generic 0 on end - end - end - device ref tcss_dma1 on - chip drivers/intel/usb4/retimer - register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)" - use tcss_usb3_port3 as dfp[0].typec_port - device generic 0 on end - end - end device ref pcie4_0 on # Enable CPU PCIE RP 1 using CLK 3 register "cpu_pcie_rp[CPU_RP(1)]" = "{