Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35905 )
Change subject: mediatek/mt8183: keep XO_SOC always in Full Power Mode ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35905/1//COMMIT_MSG@10 PS1, Line 10: as a workaround
Like Paul said, if this is a workaround please state the pros and cons of it.
Done
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@11 PS2, Line 11: test[1]
Please add a space before [.
Done
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@15 PS2, Line 15: [1] https://issuetracker.google.com/issues/136980838
I believe there is a tag for issues in the Google bug tracker.
Done
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@16 PS2, Line 16:
BUG=b:136980838
Done
https://review.coreboot.org/c/coreboot/+/35905/2/src/soc/mediatek/mt8183/rtc... File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/c/coreboot/+/35905/2/src/soc/mediatek/mt8183/rtc... PS2, Line 416: * FIXME: Also keep XO_SOC always in Full Power Mode.
… to fix resume issues from suspend. […]
Done