Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )
Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................
Patch Set 3:
(1 comment)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/49205/comment/da9daf40_ed107745 PS3, Line 970: default: : bad:
I would not call this interleaved, though. It's fully contained in the […]
I don't think you can use goto with case labels. Something that would work:
#if CONFIG(CARDBUS_PLUGIN_SUPPORT) case PCI_HEADER_TYPE_CARDBUS: dev->ops = &default_cardbus_ops_bus; break; #endif default: goto bad; }
return;
bad: if (dev->enabled) { printk(BIOS_ERR, "%s [%04x/%04x/%06x] has unknown " "header type %02x, ignoring.\n", dev_path(dev), dev->vendor, dev->device, dev->class >> 8, dev->hdr_type); } }