build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31850 )
Change subject: soc/intel/cannonlake: Allow mainboard to override DRAM part number
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31850/1/src/soc/intel/cannonlake/romstage/ro...
File src/soc/intel/cannonlake/romstage/romstage.c:
https://review.coreboot.org/#/c/31850/1/src/soc/intel/cannonlake/romstage/ro...
PS1, Line 44: }
void function return statements are not generally useful
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b2d4c33fc378b9a24b111971ec2bfdb5f8d57d0
Gerrit-Change-Number: 31850
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Mar 2019 03:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment