Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81854?usp=email )
Change subject: gfxtest: Fix out-of-order components, permanently ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/81854/comment/fd3b540c_507166c8 : PS1, Line 7: gfxtest: Fix out-of-order components, permanently Technically, there is nothing to fix, how about:
gfxtest: Introduce From_RGB constructor for Pixel_Type
File gfxtest/hw-gfx-gma-gfx_test.adb:
https://review.coreboot.org/c/libgfxinit/+/81854/comment/ea109250_50215ab3 : PS1, Line 60: for Pixel_Type use record : Blue at 0 range 0 .. 7; : Green at 1 range 0 .. 7; : Red at 2 range 0 .. 7; : Alpha at 3 range 0 .. 7; : end record; Could replace this with a `with Packed` for the record then.
https://review.coreboot.org/c/libgfxinit/+/81854/comment/296fd00a_b18bb3cf : PS1, Line 67: RGB or `From_RGBA`?