Attention is currently required from: Andrey Petrov, Arthur Heymans, Sean Rhodes.
Werner Zeh has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/65272?usp=email )
Change subject: soc/intel/apollolake: Add support for IFWI Measured Boot ......................................................................
Patch Set 52:
(4 comments)
File src/soc/intel/apollolake/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/65272/comment/3f80a6a8_810b21f0?usp... : PS50, Line 10: bootblock-y
Done
I guess you mixed it up here, or? My comment was to change line 10, not line 8. The entriy in line 8 was OK so.
File src/soc/intel/apollolake/measured_boot.c:
https://review.coreboot.org/c/coreboot/+/65272/comment/b73bd18e_5d63d3ab?usp... : PS35, Line 18: *(uint64_t *)(uint32_t)(BASE_4GB - 0x40);
I think you should use the readx ops here. […]
This should be solved with the latest patch set.
File src/soc/intel/apollolake/measured_boot.c:
https://review.coreboot.org/c/coreboot/+/65272/comment/e44ec128_a455ec37?usp... : PS50, Line 19: read32((uint64_t *)(BASE_4GB - 0x40));
Not going to pretend I follow entirely, but seems to not break anything!
It is basically the same offset you are hard coded before. If this works then I am fine.
https://review.coreboot.org/c/coreboot/+/65272/comment/04ebd7a4_31134d07?usp... : PS50, Line 67: sizeof(bpm_info->txe_hash) - 1)
Like that?
Yes, this looks better IMO.