David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43509 )
Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee...
PS4, Line 125: register "generic.probed" = "1"
do you need to probe for the trackpad or can you assume it's always present?
We will support multi-source touchpad devices. Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b
Gerrit-Change-Number: 43509
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Jul 2020 01:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment