Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31685 )
Change subject: device/pci_ops: Reuse romstage PCI config for ramstage
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31685/4/src/include/device/pci_type.h
File src/include/device/pci_type.h:
https://review.coreboot.org/#/c/31685/4/src/include/device/pci_type.h@29
PS4, Line 29: #define PCI_BDF(dev) pcidev_assert((dev))
Why the macro? Why not just name the function pcidev_bdf()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9364cb34fe8127972c772516a0a0b1d281c5ed00
Gerrit-Change-Number: 31685
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Mar 2019 13:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment