Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )
Change subject: mainboard/google/mistral: Add support for Mistral ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/chromeo... File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/chromeo... PS2, Line 38: RW_XBL_BUFFER_A@0x1E8000 0x4000
Please justify what you need all the non-standard sections in here for. […]
Ok. Infact we were asked to have the same FMAP layout as in Gale (https://partnerissuetracker.corp.google.com/issues/122557977). So from this, https://review.coreboot.org/c/coreboot/+/30902/11, switched to Gale FMAP. Have a couple of comments from Patrick on that. On top of that, we might need little more changes as we add more features like DDR CDT data etc later, but based on what is correct for the product requirement, we can stick to either Cheza or Gale layout.