Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43310 )
Change subject: soc/amd/picasso: Add dummy spinlock for psp_verstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43310/2/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/43310/2/src/soc/amd/picasso/psp_ver...
PS2, Line 15: #define boot_cpu() 1
I wasn't following the discussion around arch/ that closely. […]
Just want to point out that this is a copy of an existing file in the tree.
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
If the 3 +2 reviews needed to submit should be restricted to only fixing breakages in the coreboot master build, maybe the rule should be updated so that everyone else understands that expectation. Currently, that's not stated, so if that's the expectation, nobody else knows it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea6f31e500e1b26f0b974c6eaa486209b9c81459
Gerrit-Change-Number: 43310
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 16:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment