Attention is currently required from: Michał Żygowski.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74402 )
Change subject: mb/msi/ms_7d25: Clear recovery request in mainboard_final ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: It feels a bit wrong to do this from mainboard code. Mainboard code is usually just supposed to be about supporting the hardware, not about boot policy or what payload you want to run or stuff like that. There's no fundamental reason why for your mainboard hardware this should be called here when for others it isn't... it has more to do with what payload you run and how the rest of your firmware stack looks.
I think it would probably be more appropriate to implement this in generic code (vboot/bootmode.c sounds fine), maybe as a late ramstage boot state hook, controlled by a separate menuconfig-visible Kconfig so users can choose what makes sense for their platform. You could make it `default y if !CHROMEOS`, that should do the right thing for most use cases.