build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31557 )
Change subject: rtc: Fix rtc_calc_weekday ......................................................................
Patch Set 3:
(22 comments)
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c File src/lib/rtc.c:
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@49 PS3, Line 49: + (13 * m - 1) / 5 code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@49 PS3, Line 49: + (13 * m - 1) / 5 please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@50 PS3, Line 50: + D code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@50 PS3, Line 50: + D please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@51 PS3, Line 51: + (D >> 2) code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@51 PS3, Line 51: + (D >> 2) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@52 PS3, Line 52: + (C >> 2) code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@52 PS3, Line 52: + (C >> 2) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@53 PS3, Line 53: - 2 * C; code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@53 PS3, Line 53: - 2 * C; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@54 PS3, Line 54: tm->wday = f % 7; code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@54 PS3, Line 54: tm->wday = f % 7; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@55 PS3, Line 55: return 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@55 PS3, Line 55: return 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@133 PS3, Line 133: "Time: %2d:%02d:%02d\n", code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@133 PS3, Line 133: "Time: %2d:%02d:%02d\n", please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@134 PS3, Line 134: tm->year, tm->mon, tm->mday, code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@134 PS3, Line 134: tm->year, tm->mon, tm->mday, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@135 PS3, Line 135: (tm->wday < 0 || tm->wday > 6) ? "unknown " : weekdays[tm->wday], code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@135 PS3, Line 135: (tm->wday < 0 || tm->wday > 6) ? "unknown " : weekdays[tm->wday], please, no spaces at the start of a line
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@136 PS3, Line 136: tm->hour, tm->min, tm->sec); code indent should use tabs where possible
https://review.coreboot.org/#/c/31557/3/src/lib/rtc.c@136 PS3, Line 136: tm->hour, tm->min, tm->sec); please, no spaces at the start of a line