Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely necessary.
I do insist. It's consistent with the tree and the advantages of always building it on BROADWELL_DE outweigh the small increase in buildtime.
I tested with BUILD_TIMELESS=1 and without VBOOT (so nothing calling the functions) the resulting binary is the same with or without those options.