Attention is currently required from: Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61801 )
Change subject: acpi: Use ACPI macros to configure USB port _PLD object
......................................................................
Patch Set 3:
(1 comment)
File src/include/acpi/acpi_pld.h:
https://review.coreboot.org/c/coreboot/+/61801/comment/6b8d9373_e5692858
PS3, Line 31: enum acpi_pld_horizontal_position {
Do you mean follow the original enum? If we can get the new ACPI definition, sure.
yes, that's what I meant.
Otherwise, we should adapt it as alternative keep the same value.
Agree, I just want to wait to either modify the original enum or add a new enum as you have suggested.
WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I245b17019b6d3c5e380c16cb3c9f4edc4dd10cc6
Gerrit-Change-Number: 61801
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Won Chung
wonchung@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 15 Feb 2022 13:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment