Attention is currently required from: Benjamin Doron, David Milosevic, Julius Werner, Lean Sheng Tan, Martin L Roth, Maximilian Brune.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78285?usp=email )
Change subject: arch/arm64: Implement initial set of SMBIOS tables
......................................................................
Patch Set 15:
(3 comments)
File src/arch/arm64/smbios.c:
https://review.coreboot.org/c/coreboot/+/78285/comment/dbd6b423_f3687a63 :
PS15, Line 74: t->core_count = MAX_CPUS_ENABLED(t->core_count2);
: t->thread_count = MAX_CPUS_ENABLED(t->thread_count2);
SMP is now a thing in ARM right? Maybe the SOC should provide this info? Maybe add a TODO comment?
File src/arch/arm64/tables.c:
https://review.coreboot.org/c/coreboot/+/78285/comment/af98ded6_88f0d09b :
PS15, Line 26: high_table_pointer, new_high_table_pointer;
'high' is x86 terminology where 'low' means 0 - 1*MiB. I don't that terminology should be reused on arm64. maybe smbios_begin and smbios_end?
https://review.coreboot.org/c/coreboot/+/78285/comment/b5957899_0e90da04 :
PS15, Line 32: if (!high_table_pointer)
: return;
You want assert or error message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78285?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iedae0f26f168bd6d3af866e35d9d39ddb01abc15
Gerrit-Change-Number: 78285
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Mon, 22 Apr 2024 08:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment