Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83477?usp=email )
Change subject: drivers/pc80/rtc/mc146818rtc: Use macros for CMOS addresses ......................................................................
drivers/pc80/rtc/mc146818rtc: Use macros for CMOS addresses
Replace integer literals with macros for CMOS addresses for readability.
Change-Id: I454662c90fabb41af864728febdefa57f5ff2cb2 Signed-off-by: Yu-Ping Wu yupingso@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/83477 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/drivers/pc80/rtc/mc146818rtc.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index 6474ecb..b4ddadd 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -97,9 +97,9 @@
if (invalid || cmos_invalid || checksum_invalid) { if (!CONFIG(USE_OPTION_TABLE)) { - cmos_write(0, 0x01); - cmos_write(0, 0x03); - cmos_write(0, 0x05); + cmos_write(0, RTC_CLK_SECOND_ALARM); + cmos_write(0, RTC_CLK_MINUTE_ALARM); + cmos_write(0, RTC_CLK_HOUR_ALARM); for (i = 10; i < 128; i++) cmos_write(0, i); cleared_cmos = true;