Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42224 )
Change subject: soc/amd/common/blocks/gpio: Introduce gpio_get_bar ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/acpi/gpi... File src/soc/amd/common/acpi/gpio_bank_lib.asl:
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/acpi/gpi... PS4, Line 9: Return (Add(Multiply(Arg0, 4), ACPIMMIO_GPIO_BASE))
The code here implies the banks are one after each other in ACPIMMIO space, splitting to banks appea […]
Reverted to old code.
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42224/4/src/soc/amd/common/block/gp... PS4, Line 95: bar += gpio_get_offset(gpio_num);
Here is the assembly injected for current master: […]
Changed code. I looked at cb:37324, and I'll see about rebasing the psp_verstage patches on top of that and getting it working.