HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: Treewide: Add '-Wduplicated-branches' warning option
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39561/4/src/device/dram/ddr3.c
File src/device/dram/ddr3.c:
https://review.coreboot.org/c/coreboot/+/39561/4/src/device/dram/ddr3.c@165
PS4, Line 165: printram(" Capacity : ", (capacity_shift < 0x02) ?
Is this required by the '-Wduplicated-branches' check? It might fail only because printram defaults […]
yes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie433f32a423ce32ea2bd5ae09a1718341cd2b672
Gerrit-Change-Number: 39561
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 15 Apr 2020 12:28:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment