Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 5:
(7 comments)
Nice.
https://review.coreboot.org/c/coreboot/+/34537/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34537/5//COMMIT_MSG@9 PS5, Line 9: So far the bootsplash is only correctly rendered if the framebuffer were : setup as 1027x768@16. On what device?
https://review.coreboot.org/c/coreboot/+/34537/5//COMMIT_MSG@9 PS5, Line 9: were : setup as 1027x768@16 is set up as …
(Really 1027?)
https://review.coreboot.org/c/coreboot/+/34537/5//COMMIT_MSG@9 PS5, Line 9: So far the bootsplash is only correctly rendered if the framebuffer were : setup as 1027x768@16. : This commit removes this limit by using the actual resolutions and combines : the code for x86 and yabel. : For the moment the bootsplash is still limited to VGA-OptionROM framebuffer init. Please add an empty line between paragraphs.
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/bootsplash... PS5, Line 19: u16 x_resolution, u16 y_resolution, u16 fb_resolution); Please add a documentation for the function (return code), and so on.
Why u16, and not `unsigned int`?
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/bootsplash... File src/device/oprom/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/bootsplash... PS5, Line 28: -1 Please think about using the enums `CB_SUCCESS`, and friends.
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/realmode/x... PS5, Line 372: Bootsplash bootsplash
https://review.coreboot.org/c/coreboot/+/34537/5/src/device/oprom/realmode/x... PS5, Line 377: BIOS_WARNING BIOS_ERROR