Attention is currently required from: Sean Rhodes.
Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75854?usp=email )
Change subject: soc/intel/apollolake: Switch to snake case for DisableComplianceMode ......................................................................
soc/intel/apollolake: Switch to snake case for DisableComplianceMode
For a unification of the naming convension, change from pascal case to snake case style for parameter 'DisableComplianceMode'.
Change-Id: I9d5605134a753f161a66857c7f78844ae7490cd6 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/google/octopus/variants/bloog/overridetree.cb M src/mainboard/google/octopus/variants/bobba/overridetree.cb M src/mainboard/google/octopus/variants/casta/overridetree.cb M src/mainboard/google/octopus/variants/dood/overridetree.cb M src/mainboard/google/octopus/variants/fleex/overridetree.cb M src/mainboard/google/octopus/variants/foob/overridetree.cb M src/mainboard/google/octopus/variants/garg/overridetree.cb M src/mainboard/google/octopus/variants/lick/overridetree.cb M src/mainboard/google/octopus/variants/meep/overridetree.cb M src/mainboard/google/octopus/variants/phaser/overridetree.cb M src/mainboard/starlabs/lite/variants/glk/devicetree.cb M src/mainboard/starlabs/lite/variants/glkr/devicetree.cb M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h 14 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/75854/1
diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb index 83880ec..b4388c1 100644 --- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb @@ -168,5 +168,5 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb index 8a48d22..31c1463 100644 --- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb @@ -227,6 +227,6 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" register "disable_xhci_lfps_pm" = "0" end diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index dce4d00..c7540c8 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -150,5 +150,5 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/google/octopus/variants/dood/overridetree.cb b/src/mainboard/google/octopus/variants/dood/overridetree.cb index de923c4..9b4126d 100644 --- a/src/mainboard/google/octopus/variants/dood/overridetree.cb +++ b/src/mainboard/google/octopus/variants/dood/overridetree.cb @@ -162,6 +162,6 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" register "disable_xhci_lfps_pm" = "0" end diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index 9a4cdee..b8444e5 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -85,7 +85,7 @@ }"
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" register "disable_xhci_lfps_pm" = "0"
device domain 0 on diff --git a/src/mainboard/google/octopus/variants/foob/overridetree.cb b/src/mainboard/google/octopus/variants/foob/overridetree.cb index c47b0de..274aead 100644 --- a/src/mainboard/google/octopus/variants/foob/overridetree.cb +++ b/src/mainboard/google/octopus/variants/foob/overridetree.cb @@ -163,5 +163,5 @@ end
# Disable xHCI compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/google/octopus/variants/garg/overridetree.cb b/src/mainboard/google/octopus/variants/garg/overridetree.cb index 86b4342..459e5b3 100644 --- a/src/mainboard/google/octopus/variants/garg/overridetree.cb +++ b/src/mainboard/google/octopus/variants/garg/overridetree.cb @@ -204,6 +204,6 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" register "disable_xhci_lfps_pm" = "0" end diff --git a/src/mainboard/google/octopus/variants/lick/overridetree.cb b/src/mainboard/google/octopus/variants/lick/overridetree.cb index b74417b..551a2ba 100644 --- a/src/mainboard/google/octopus/variants/lick/overridetree.cb +++ b/src/mainboard/google/octopus/variants/lick/overridetree.cb @@ -116,5 +116,5 @@
# Disable compliance mode
- register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/google/octopus/variants/meep/overridetree.cb b/src/mainboard/google/octopus/variants/meep/overridetree.cb index 6623fa0..727b468 100644 --- a/src/mainboard/google/octopus/variants/meep/overridetree.cb +++ b/src/mainboard/google/octopus/variants/meep/overridetree.cb @@ -248,5 +248,5 @@ end
# Disable compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/google/octopus/variants/phaser/overridetree.cb b/src/mainboard/google/octopus/variants/phaser/overridetree.cb index 748481d..472676f 100644 --- a/src/mainboard/google/octopus/variants/phaser/overridetree.cb +++ b/src/mainboard/google/octopus/variants/phaser/overridetree.cb @@ -202,5 +202,5 @@ end
# Disable xHCI compliance mode - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1" end diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb index fb9070f..abfbc0a 100644 --- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb @@ -31,7 +31,7 @@ register "prt0_gpio" = "GPIO_PRT0_UDEF"
register "usb_config_override" = "1" - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1"
register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED" register "pcie_rp_clkreq_pin[1]" = "CLKREQ_DISABLED" diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb index b4e627c..3102b1f 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb @@ -31,7 +31,7 @@ register "prt0_gpio" = "GPIO_PRT0_UDEF"
register "usb_config_override" = "1" - register "DisableComplianceMode" = "1" + register "disable_compliance_mode" = "1"
register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED" register "pcie_rp_clkreq_pin[1]" = "CLKREQ_DISABLED" diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index 57aa085..e3bfa1e 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -607,7 +607,7 @@ /* * Options to disable XHCI Link Compliance Mode. */ - silconfig->DisableComplianceMode = cfg->DisableComplianceMode; + silconfig->DisableComplianceMode = cfg->disable_compliance_mode;
/* * Options to change USB3 ModPhy setting for Integrated Filter value. diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index 88ec1ff..c1bc020 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -184,7 +184,7 @@ * disable Compliance Mode. Set TRUE to disable Compliance Mode. * 0:FALSE(Default), 1:True. */ - uint8_t DisableComplianceMode; + uint8_t disable_compliance_mode;
/* Options to change USB3 ModPhy setting for the Integrated Filter (IF) * value. Default is 0 to not changing default IF value (0x12). Set