Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41943 )
Change subject: sb/intel/lynxpoint: Clean up code ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/chip.h:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 108: #endif /* SOUTHBRIDGE_INTEL_LYNXPOINT_CHIP_H */
Which purpose?
Undid
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/early_usb.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 24: */
Will change back
Undid, and changed "Setup" to "Set up" as it's a verb
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/elog.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 33: u32 gpe0_en = inl(get_pmbase() + gpe0_en_reg);
I'll drop it
Undid
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 148: u32 viddid, const u32 **verb)
Will change back
Undid
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 464: RCBA32_AND_OR(0x333c, 0xffcfffff, 0x00c00000); // SATA : : RCBA32_OR(0x38c0, 0x3c07); // SPI Dynamic :
Will change back
Undid